Add all missing fields to ResponseItem and related classes.#326
Conversation
Fix types to match Go code.
There was a problem hiding this comment.
are you sure that error can't exist without error details? Shouldn't be it ORed?
There was a problem hiding this comment.
If either is not null, its an error. Only when both are null (i.e. 'and') is it safe to return false.
There was a problem hiding this comment.
I think this method should be pushed up to ResponseItem class. Then it should be used in BuildResponseItem.isBuildSuccessIndicated() and PullResponseItem.isPullSuccessIndicated() as pre-condition check.
There was a problem hiding this comment.
Such refactoring is exceeding the scope of this pull request, which is to get docker-java to stop rejecting valid ProgressDetail messages.
|
@llamahunter Thanks for your effort! |
Now it uses deprecated method that looks weird. |
|
Where did you get doc that describes this responses? :( |
|
@KostyaSha This is documented in the related issue #322 |
3 participants
Fix types to match Go code.
fixes #322