Skip to content

removed trusty from docs to match docker ce build#7894

Closed
michaelnugent wants to merge 2 commits into
docker:masterfrom
michaelnugent:master
Closed

removed trusty from docs to match docker ce build#7894
michaelnugent wants to merge 2 commits into
docker:masterfrom
michaelnugent:master

Conversation

@michaelnugent

Copy link
Copy Markdown

Proposed changes

Removed Ubuntu Trusty (14.04 LTS) from docs since the build was removed from the docker ce code as well:
docker-archive/docker-ce@d2178be#diff-9be7b725da4b31d018cc9310c9d57ec9

This removes the need for the tab as well so I removed that structure. I also bumped the example that mentions Trusty forward to Xenial (16.04 LTS)

Unreleased project version (optional)

This applies builds of docker-ce after 18.09.0.

Related issues (optional)

Link above.

> like Linux Mint, you might need to change `$(lsb_release -cs)`
> to your parent Ubuntu distribution. For example, if you are using
> `Linux Mint Rafaela`, you could use `trusty`.
> `Linux Mint Sarah`, you could use `xenial`.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonTheTurtle

Copy link
Copy Markdown

Deploy preview for docsdocker ready!

Built with commit 1101a94

https://deploy-preview-7894--docsdocker.netlify.com

1 similar comment
@GordonTheTurtle

Copy link
Copy Markdown

Deploy preview for docsdocker ready!

Built with commit 1101a94

https://deploy-preview-7894--docsdocker.netlify.com

@GordonTheTurtle

GordonTheTurtle commented Dec 19, 2018

Copy link
Copy Markdown

Deploy preview for docsdocker ready!

Built with commit 75acb91

https://deploy-preview-7894--docsdocker.netlify.com

@michaelnugent

Copy link
Copy Markdown
Author

The -ee version of this may need to be changed as well and, if anyone wants, I can include that, but I don't know if -ee has the same support structure.

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I left some comments/suggestions below 🤗

Comment thread install/linux/docker-ce/ubuntu.md
@@ -68,36 +67,11 @@ outlined below.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the section above, we can probably change the bullet list (because all supported Ubuntu versions are now on kernel 4 or above;

 - For new installations on version 4 and higher of the Linux kernel, `overlay2`
   is supported and preferred over `aufs`.
 - For version 3 of the Linux kernel, `aufs` is supported because `overlay` or
   `overlay2` drivers are not supported by that kernel version.

Perhaps combine the first bullet with the first sentence; something like;

Docker CE on Ubuntu supports `overlay2` and `aufs` storage drivers. For new
installations, `overlay2` is the default, and preferred over `aufs`. If you
need to use `aufs`, you need to do additional preparation as outlined below.

@thaJeztah thaJeztah added the area/engine Issue affects Docker engine/daemon label Dec 19, 2018
@thaJeztah

Copy link
Copy Markdown
Member

@ahh-docker PTAL

@thaJeztah

Copy link
Copy Markdown
Member

The -ee version of this may need to be changed as well and, if anyone wants, I can include that, but I don't know if -ee has the same support structure.

For EE, we probably need to keep Trusty; Docker EE provides LTS versions of the Docker Engine, where versions 17.06, 18.03, and 18.09 are currently supported (and 17.06 and 18.03 still support being installed on Ubuntu 14.04 - see https://success.docker.com/article/compatibility-matrix)

@ghost ghost assigned ahh-docker Dec 20, 2018
@ahh-docker

ahh-docker commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

@thaJeztah PTAL. thanks! There are some merge conflicts I'm a bit hesitant to resolve since I'm not sure which is what, and if they're what you want. :)

@thaJeztah

Copy link
Copy Markdown
Member

I see I did this already in
5047fde, so looks like we no longer need this one

@ahh-docker

ahh-docker commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

@michaelnugent Thank you for your feedback! We have received and reviewed your changes. To remain consistent with existing technical specifications, we did not incorporate your suggested changes. If you have additional concerns, submit a new issue in this repository.

@ahh-docker ahh-docker closed this Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants