Possible left/right navbar sidebar menu scrollbar not visible fix#2887
Closed
shanna6 wants to merge 2 commits into
Closed
Possible left/right navbar sidebar menu scrollbar not visible fix#2887shanna6 wants to merge 2 commits into
shanna6 wants to merge 2 commits into
Conversation
When the footer is present it can cover the left side navbar because it's height is not adjusted. In "/js/docks.js" there is a function "checkNavSizes()" that fixes this issue with the right navbar "toc-nav", but two changes are needed. First in "docks.js" one line is added to also update the "col-nav". Second in "/_scss/_layout.css" "sidebar" the "height: 100% !important" must be changed to just "height: 100%" or the new script won't update correctly. The "toc-nav" uses "sidebar-wrapper" which already uses "height: 100%" and allows "checkNavSizes()" to work.
The homepage and many other pages have scrolling issues with the left and right scrollbars if content is expanded. There is a function called checkNavSizes() in docs.js that tried to fix this issue I believe but was incomplete. Because the homepage is different from the other page, a check is needed and the sidebar height is set accordingly. The other pages just needed to set the correct tags with the correct height when the footer came into view. layout.scss needed the transition style removed or setting the height would not be instant on the right side menu
Contributor
|
Sorry, @stevenhanna6 but we went with #2860 for this bug. We'll shoot you 25 points for the attempted PR. :) |
Contributor
Author
|
Yah I was impressed with allejo's fix, much cleaner and better solution by a mile, thanks for the 25pts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The homepage and many other pages have scrolling issues with the left and right scrollbars if content is expanded within them. There is a function called checkNavSizes() in docs.js that tried to fix this issue I believe but was incomplete. Because the homepage is different from the other page, a check is needed and the sidebar height to set it accordingly. The other pages just needed to set the correct tags with the correct height when the footer comes into view as was previously attempted.
layout.scss "sidebar-wrapper" needed the transition style removed or setting the height would not be instant on the right side menu. Also "sidebar" the "height: 100% !important" had to be changed to just "height: 100%" to allow the height to be set.
Related issues (optional)
Fixes: #2232