Repository navigation
unit tests on commands #37
Description
Moving initial docker/docker issue moby/moby#31217 here
This issue is to keep track of unit test for the cli (i.e. cli/commands package and sub-packages).
- bundlefile
- checkpoint @adshmh
- container (fakeClient added in Reduce cyclomatic comeplxity threshold #61) @vdemeester
- formatter
- idresolver @adshmh
- image @icapurro Unit tests for cli/command/image package moby/moby#32248
- inspect
- network (fakeClient added in Host and Bridge network support in docker stack deploy #132) @ksouf
- node
- plugin @adshmh
- prune
- registry
- secret @adshmh
- service
- stack @adshmh
- swarm
- system
- task
- trust
- volume (Add unit tests to cli/command/volume package moby/moby#31124)
The swarm, node and volume packages are example on how to write those tests (but they probably can be enhance, and enhancement are always welcome ).
- In order to write tests for these, you'll have to create more builder (
cli/internal/test/builders) for objects that are not yet there. - You can also use
goldenfiles (see examples) - For each of these package, there is some integration tests (in
integration-cli) that could be removed. I tried to mark them when I saw them, but it's not complete yet. I'll try to update this issue with a list of integration test that could be gone for each packages.
Activity
dnephin commentedon May 26, 2017
We may need to move some of the
fakeClientintocli/internal/test/and export the struct and fields. There are some packages (stack, and service at least) that use parts of other clients.jeremcs commentedon Jun 6, 2017
Some items on the list seem to be deprecated as they do not appear when setting the DOCKER_HIDE_LEGACY_COMMANDS variable:
Should we remove them from the list ?
(cc @kelu27)
vdemeester commentedon Jun 6, 2017
@jeremcs I would say not (because some of them won't ever be removed).
clook commentedon Jun 19, 2017
Starting working on service (#201)
adshmh commentedon Jun 27, 2017
#dibs on task package
adshmh commentedon Jun 30, 2017
#dibs on checkpoint package.
Zebrilee commentedon Jul 20, 2017
hi @vdemeester ,
I was working on prune test in the last hackergarten but I saw the commit two days ago which modify the prune.go file and add a prune_test.go too.
I believe this part is ok or is there something else to do?
vdemeester commentedon Jul 20, 2017
@Zebrilee oh right yeah, I should mark it on the issue
redpanda commentedon Aug 23, 2017
#dibs on network package.
add tests to plugin create/remove/enable/disable commands. Part of wo…
add tests to plugin create/remove/enable/disable commands. Part of wo…
vdemeester commentedon May 30, 2018
Closing this as all those packages have some test. We can enhance the coverage but I feel this issue can be considered as done.
Merge pull request docker#37 from andrewhsu/gen-man
add tests to plugin create/remove/enable/disable commands. Part of wo…