Skip to content

fix: propagate limit for filter#400

Merged
alaeddine-13 merged 2 commits into
mainfrom
fix-filter-limit
Jun 13, 2022
Merged

fix: propagate limit for filter#400
alaeddine-13 merged 2 commits into
mainfrom
fix-filter-limit

Conversation

@alaeddine-13

Copy link
Copy Markdown
Member

fix: ignore limit for filter

@codecov

codecov Bot commented Jun 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #400 (4f89027) into main (1482421) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files         134      134           
  Lines        6385     6385           
=======================================
  Hits         5524     5524           
  Misses        861      861           
Flag Coverage Δ
docarray 86.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/weaviate/find.py 86.66% <ø> (ø)
docarray/__init__.py 75.00% <100.00%> (ø)
docarray/array/mixins/find.py 87.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad1e1f...4f89027. Read the comment docs.

@alaeddine-13 alaeddine-13 changed the title fix: ignore limit for filter fix: propagate limit for filter Jun 13, 2022

@davidbp davidbp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaeddine-13
alaeddine-13 merged commit 64f8ff5 into main Jun 13, 2022
@alaeddine-13
alaeddine-13 deleted the fix-filter-limit branch June 13, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants