Skip to content

feat: filter in weav#373

Merged
davidbp merged 10 commits into
mainfrom
feat-weaviate-filter
Jun 2, 2022
Merged

feat: filter in weav#373
davidbp merged 10 commits into
mainfrom
feat-weaviate-filter

Conversation

@davidbp

@davidbp davidbp commented May 26, 2022

Copy link
Copy Markdown
Contributor

The objective of the PR is improve the speed when filtering with a weaviate filter.
closes: #344

@codecov

codecov Bot commented May 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #373 (335c1b1) into main (1b79312) will increase coverage by 1.71%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   84.57%   86.28%   +1.71%     
==========================================
  Files         134      134              
  Lines        6368     6382      +14     
==========================================
+ Hits         5386     5507     +121     
+ Misses        982      875     -107     
Flag Coverage Δ
docarray 86.28% <88.23%> (+1.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/weaviate/find.py 86.66% <86.66%> (+1.88%) ⬆️
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/array/mixins/match.py 75.00% <100.00%> (ø)
docarray/helper.py 76.56% <0.00%> (+0.41%) ⬆️
docarray/math/ndarray.py 90.00% <0.00%> (+0.66%) ⬆️
docarray/array/storage/memory/find.py 91.22% <0.00%> (+1.75%) ⬆️
docarray/array/storage/sqlite/seqlike.py 85.18% <0.00%> (+1.85%) ⬆️
docarray/array/mixins/io/binary.py 97.45% <0.00%> (+2.54%) ⬆️
docarray/array/storage/weaviate/seqlike.py 77.41% <0.00%> (+3.22%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5870c55...335c1b1. Read the comment docs.

@alaeddine-13
alaeddine-13 marked this pull request as ready for review May 30, 2022 15:50
Comment thread docarray/array/storage/weaviate/find.py Outdated
@davidbp
davidbp requested a review from JoanFM June 1, 2022 10:19
Comment thread docarray/array/storage/weaviate/find.py Outdated
Comment thread docarray/array/storage/weaviate/find.py Outdated
Comment thread docs/advanced/document-store/weaviate.md Outdated
Comment thread docs/advanced/document-store/weaviate.md Outdated
Comment thread docs/advanced/document-store/weaviate.md Outdated
Comment thread docs/advanced/document-store/weaviate.md Outdated
Comment thread docs/advanced/document-store/weaviate.md Outdated
Comment thread docs/advanced/document-store/weaviate.md Outdated
Comment thread docs/advanced/document-store/weaviate.md Outdated
@github-actions

github-actions Bot commented Jun 2, 2022

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-weaviate-filter--jina-docs.netlify.app 🎉

@davidbp
davidbp merged commit 2098aa7 into main Jun 2, 2022
@davidbp
davidbp deleted the feat-weaviate-filter branch June 2, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support filtering for weaviate

3 participants