Skip to content

ISSUE-316 Fix caching for CNAME and DNAME #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dropofwill wants to merge 1 commit into from
+4 −4
Closed

ISSUE-316 Fix caching for CNAME and DNAME #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/xbill/DNS/SetResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,10 @@ public boolean isSuccessful() {

/** If the query was successful, return the answers */
public List<RRset> answers() {
if (type != SUCCESSFUL) {
return null;
if (type == SUCCESSFUL || type == CNAME || type == DNAME) {
return data;
}
return data;
return null;
}

/** If the query encountered a CNAME, return it. */
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/xbill/DNS/lookup/LookupSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ private CompletionStage<LookupResult> setResponseToMessageFuture(
return completeExceptionally(
new NoSuchRRSetException(queryRecord.getName(), queryRecord.getType()));
}
if (setResponse.isSuccessful()) {
if (setResponse.isSuccessful() || setResponse.isCNAME() || setResponse.isDNAME()) {
List<Record> records =
setResponse.answers().stream()
.flatMap(rrset -> rrset.rrs(cycleResults).stream())
Expand Down