Fix cross-thread access to package objects during Python script evaluation in wizards#651
Open
marvinoe21 wants to merge 7 commits intomasterfrom
Open
Fix cross-thread access to package objects during Python script evaluation in wizards#651marvinoe21 wants to merge 7 commits intomasterfrom
marvinoe21 wants to merge 7 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a thread-affinity issue in Python scripting wizards. Package objects were cloned on the GUI thread and added to the Python context, while script evaluation was executed asynchronously on a different thread. When a script accessed one of these package objects, Qt could report thread-related assertion messages.
The fix moves wizard script evaluation to a dedicated worker thread and temporarily moves the exposed package objects to that thread for the duration of the evaluation. After the script finishes, the objects are moved back to the GUI thread. Live code completion is temporarily disabled while a script is running, because completion introspection could otherwise access the package objects from the GUI thread and trigger the same issue. As part of the cleanup, the old
GtpyScriptRunnablewas removed.Fixes #650