update scala-xml#237
Merged
Merged
Conversation
fix dispatch#235 lift-json also depends on scala-xml 1.2. lift-json is not maintained anymore. I propose to remove the module.
Contributor
Author
|
@farmdawgnation can you authorize the PR checks? |
Member
|
Yeah. I’ll have a look today. On Jan 30, 2023, at 3:38 AM, Yann Simon ***@***.***> wrote:
@farmdawgnation can you authorize the PR checks?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
PR checks are authorized. Will noodle on how I feel about actually pulling the plug on lift-json support but alas, I'm also one of the key maintainers over there and I'm not sure it's aged particularly well. |
Member
|
Checks have all passed... give me a bit to think about the lift-json question. |
farmdawgnation
approved these changes
Feb 2, 2023
farmdawgnation
left a comment
farmdawgnation
left a comment
Member
There was a problem hiding this comment.
Approved, though I think I'll have to consider this a major version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #235
lift-json also depends on scala-xml 1.2.
lift-json is not maintained anymore.
I propose to remove the module.