Add PancakeGraph#403
Conversation
james-d-mitchell
force-pushed
the
pancake
branch
from
de88a27 to
4d98f96
Compare
This comment has been minimized.
This comment has been minimized.
james-d-mitchell
force-pushed
the
pancake
branch
from
4d98f96 to
742fd47
Compare
james-d-mitchell
force-pushed
the
pancake
branch
from
742fd47 to
5d6f25c
Compare
james-d-mitchell
force-pushed
the
pancake
branch
from
5d6f25c to
48b4adf
Compare
|
@james-d-mitchell merge conflicts now should be resolved... |
james-d-mitchell
force-pushed
the
pancake
branch
4 times, most recently
from
32a217f to
95ec1bb
Compare
wilfwilson
left a comment
wilfwilson
left a comment
There was a problem hiding this comment.
Nice graph! I have a few comments/suggestions/complaints.
I would much prefer it if this PR consisted of two separate commits: one for the changes to CayleyDigraph, and one for the pancake stuff.
|
Just a reminder, there is a pull request on this branch about the burnt pancake graph (which has to do with signed permutations). I haven't finished documented it yet, but I guess I should do this and @james-d-mitchell should approve before merging this into master, if we still want burnt pancake as a family of graphs in digraphs :) |
james-d-mitchell
force-pushed
the
pancake
branch
2 times, most recently
from
2666a8f to
fdb8832
Compare
LRacine
left a comment
LRacine
left a comment
There was a problem hiding this comment.
I really enjoyed looking through your code, it was clean and concise. Your documentation was also thorough and readable. There were just a couple of capitalisation errors and I was wondering where I could see the burnt pancake documentation.
james-d-mitchell
force-pushed
the
pancake
branch
from
f1cb6a1 to
2079807
Compare
james-d-mitchell
added
the
gap-days-brussels-2025
james-d-mitchell
force-pushed
the
pancake
branch
from
2079807 to
a6ba643
Compare
| InstallMethod(CayleyDigraph, "for a group and list of elements", | ||
| [IsGroup, IsHomogeneousList], | ||
| {G, gens} -> CayleyDigraphCons(IsImmutableDigraph, G, gens)); | ||
|
|
||
| InstallMethod(CayleyDigraph, "for a filter and group with generators", | ||
| [IsFunction, IsGroup, IsHomogeneousList], CayleyDigraphCons); | ||
|
|
||
| InstallMethod(CayleyDigraph, "for a group with generators", | ||
| [IsGroup and HasGeneratorsOfGroup], | ||
| G -> CayleyDigraph(G, GeneratorsOfGroup(G))); | ||
| G -> CayleyDigraphCons(IsImmutableDigraph, G, GeneratorsOfGroup(G))); | ||
|
|
||
| InstallMethod(CayleyDigraph, "for a filter and group with generators", | ||
| [IsFunction, IsGroup and HasGeneratorsOfGroup], | ||
| {filt, G} -> CayleyDigraphCons(filt, G, GeneratorsOfGroup(G))); |
There was a problem hiding this comment.
Could you add docs for these new overloads?
|
A wonderful graph to have in our library, thanks James. Looks good and tests pass on my end, just one documentation improvement and should be good to merge. |
Co-authored-by: Reinis Cirpons <[email protected]>
Done, I'll merge when/if the CI passes. |
7 participants
No description provided.