Skip to content

Setup code coverage reporting - #45

Merged
rlskoeser merged 12 commits into
mainfrom
coverage
Nov 14, 2022
Merged

Setup code coverage reporting#45
rlskoeser merged 12 commits into
mainfrom
coverage

Conversation

@rlskoeser

@rlskoeser rlskoeser commented Nov 11, 2022

Copy link
Copy Markdown
Member

#46

this is what the coverage report looks like for this branch: https://app.codecov.io/gh/dh-tech/hackathon-2022/tree/coverage/undate

@codecov

codecov Bot commented Nov 11, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@05404f2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage        ?   97.29%           
=======================================
  Files           ?        4           
  Lines           ?      111           
  Branches        ?        0           
=======================================
  Hits            ?      108           
  Misses          ?        3           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rlskoeser rlskoeser changed the title See if we can use slipcover JSON with codecov Setup code coverage reporting Nov 11, 2022

@ColeDCrawford ColeDCrawford left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though I don't have much experience implementing code coverage. Thanks for adding, cool to see!

@rlskoeser

rlskoeser commented Nov 14, 2022

Copy link
Copy Markdown
Member Author

Thanks for reviewing, @ColeDCrawford!

I was thinking that my changes conflicted with @maltevogl's setup config changes branch and that his should be merged first so I can reconcile the differences.

Update local changes to work with tox/setup.cfg
@rlskoeser
rlskoeser merged commit 79efc4d into main Nov 14, 2022
@rlskoeser
rlskoeser deleted the coverage branch November 14, 2022 21:41
@rlskoeser rlskoeser mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants