Repository navigation
Move in-package test directories to under /tests - #41
Merged
Merged
Conversation
This patch was brought on by a new effect in `mypy` v0.990 causing various test-library import patterns to fail typing review. A deployed package typically does not require shipping its tests via e.g. PyPI. Following this design spirit, and to address the new `mypy` review errors, this patch moves tests out of the `/dfxml` directory to under `/tests/misc_*`. Each new `misc` directory gets a README that there still is an outstanding TODO on forward-porting the tests from their initial coding style. The Makefiles are updated to work as well as they did before this file motion. Signed-off-by: Alex Nelson <[email protected]>
…eck-tools This patch retires Python 2 (EOL'd) from the testing now in `tests/misc_object_tests`. Signed-off-by: Alex Nelson <[email protected]>
Contributor
Author
|
Scope creep: I missed the Github Action was calling another Make target, which led to paying down some technical debt from grad. school. |
Signed-off-by: Alex Nelson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch was brought on by a new effect in
mypyv0.990 causing various test-library import patterns to fail typing review.A deployed package typically does not require shipping its tests via e.g. PyPI. Following this design spirit, and to address the new
mypyreview errors, this patch moves tests out of the/dfxmldirectory to under/tests/misc_*. Each newmiscdirectory gets a README that there still is an outstanding TODO on forward-porting the tests from their initial coding style.The Makefiles are updated to work as well as they did before this file motion.