Skip to content

Commit d1de9ff

Browse files
alexeaglebenlesh
alexeagle
authored and
benlesh
committed
build: update to latest rules_nodejs (angular#27764)
This includes a performance fix for module resolution in the common case under Ivy PR Close angular#27764
1 parent 707c682 commit d1de9ff

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎packages/bazel/package.bzl‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ def rules_angular_dependencies():
1919
#
2020
# Download Bazel toolchain dependencies as needed by build actions
2121
# Use a SHA to get fix for needing symlink_prefix during npm publishing
22-
# TODO(alexeagle): updated to next tagged rules_typescript release
22+
# TODO(alexeagle): update to release later than 0.16.4
2323
_maybe(
2424
http_archive,
2525
name = "build_bazel_rules_nodejs",
26-
url = "https://github.com/bazelbuild/rules_nodejs/archive/ee218e2a98b9f09ba07cecac8496a5918c47bc5d.zip",
27-
strip_prefix = "rules_nodejs-ee218e2a98b9f09ba07cecac8496a5918c47bc5d",
26+
url = "https://github.com/bazelbuild/rules_nodejs/archive/bbf31af8aafad8dd5193356081c6b233ba143aa3.zip",
27+
strip_prefix = "rules_nodejs-bbf31af8aafad8dd5193356081c6b233ba143aa3",
2828
)
2929

3030
_maybe(

‎packages/bazel/src/ng_rollup_bundle.bzl‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ def _plain_rollup_bundle(ctx):
9595
run_uglify(ctx, ctx.outputs.build_es5, ctx.outputs.build_es5_min_debug, debug = True)
9696
umd_rollup_config = write_rollup_config(ctx, filename = "_%s_umd.rollup.conf.js", output_format = "umd")
9797
run_rollup(ctx, collect_es2015_sources(ctx), umd_rollup_config, ctx.outputs.build_umd)
98+
cjs_rollup_config = write_rollup_config(ctx, filename = "_%s_cjs.rollup.conf.js", output_format = "cjs")
99+
run_rollup(ctx, collect_es2015_sources(ctx), cjs_rollup_config, ctx.outputs.build_cjs)
98100
run_sourcemapexplorer(ctx, ctx.outputs.build_es5_min, source_map, ctx.outputs.explore_html)
99101

100102
run_brotli(ctx, ctx.outputs.build_es5_min, ctx.outputs.build_es5_min_compressed)
@@ -134,6 +136,8 @@ def _ng_rollup_bundle(ctx):
134136

135137
umd_rollup_config = write_rollup_config(ctx, filename = "_%s_umd.rollup.conf.js", output_format = "umd")
136138
run_rollup(ctx, collect_es2015_sources(ctx), umd_rollup_config, ctx.outputs.build_umd)
139+
cjs_rollup_config = write_rollup_config(ctx, filename = "_%s_cjs.rollup.conf.js", output_format = "cjs")
140+
run_rollup(ctx, collect_es2015_sources(ctx), cjs_rollup_config, ctx.outputs.build_cjs)
137141

138142
run_brotli(ctx, ctx.outputs.build_es5_min, ctx.outputs.build_es5_min_compressed)
139143

0 commit comments

Comments
 (0)