Skip to content

Commit 5da55d6

Browse files
marclavalmatsko
marclaval
authored and
matsko
committed
test(ivy): add root cause analysis for failing router tests (angular#27792)
PR Close angular#27792
1 parent 50a91ba commit 5da55d6

1 file changed

Lines changed: 49 additions & 49 deletions

File tree

‎packages/router/test/integration.spec.ts‎

Lines changed: 49 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -4074,27 +4074,27 @@ describe('Integration', () => {
40744074
});
40754075
});
40764076

4077-
fixmeIvy('unknown').it(
4078-
'should use the injector of the lazily-loaded configuration',
4079-
fakeAsync(inject(
4080-
[Router, Location, NgModuleFactoryLoader],
4081-
(router: Router, location: Location, loader: SpyNgModuleFactoryLoader) => {
4082-
loader.stubbedModules = {expected: LoadedModule};
4083-
4084-
const fixture = createRoot(router, RootCmp);
4085-
4086-
router.resetConfig([{
4087-
path: 'eager-parent',
4088-
component: EagerParentComponent,
4089-
children: [{path: 'lazy', loadChildren: 'expected'}]
4090-
}]);
4091-
4092-
router.navigateByUrl('/eager-parent/lazy/lazy-parent/lazy-child');
4093-
advance(fixture);
4094-
4095-
expect(location.path()).toEqual('/eager-parent/lazy/lazy-parent/lazy-child');
4096-
expect(fixture.nativeElement).toHaveText('eager-parent lazy-parent lazy-child');
4097-
})));
4077+
fixmeIvy('FW-887: JIT: compilation of NgModule')
4078+
.it('should use the injector of the lazily-loaded configuration',
4079+
fakeAsync(inject(
4080+
[Router, Location, NgModuleFactoryLoader],
4081+
(router: Router, location: Location, loader: SpyNgModuleFactoryLoader) => {
4082+
loader.stubbedModules = {expected: LoadedModule};
4083+
4084+
const fixture = createRoot(router, RootCmp);
4085+
4086+
router.resetConfig([{
4087+
path: 'eager-parent',
4088+
component: EagerParentComponent,
4089+
children: [{path: 'lazy', loadChildren: 'expected'}]
4090+
}]);
4091+
4092+
router.navigateByUrl('/eager-parent/lazy/lazy-parent/lazy-child');
4093+
advance(fixture);
4094+
4095+
expect(location.path()).toEqual('/eager-parent/lazy/lazy-parent/lazy-child');
4096+
expect(fixture.nativeElement).toHaveText('eager-parent lazy-parent lazy-child');
4097+
})));
40984098
});
40994099

41004100
it('works when given a callback',
@@ -4417,43 +4417,43 @@ describe('Integration', () => {
44174417
class LazyLoadedModule {
44184418
}
44194419

4420-
fixmeIvy('unknown').it(
4421-
'should not ignore empty path when in legacy mode',
4422-
fakeAsync(inject(
4423-
[Router, NgModuleFactoryLoader],
4424-
(router: Router, loader: SpyNgModuleFactoryLoader) => {
4425-
router.relativeLinkResolution = 'legacy';
4426-
loader.stubbedModules = {expected: LazyLoadedModule};
4420+
fixmeIvy('FW-887: JIT: compilation of NgModule')
4421+
.it('should not ignore empty path when in legacy mode',
4422+
fakeAsync(inject(
4423+
[Router, NgModuleFactoryLoader],
4424+
(router: Router, loader: SpyNgModuleFactoryLoader) => {
4425+
router.relativeLinkResolution = 'legacy';
4426+
loader.stubbedModules = {expected: LazyLoadedModule};
44274427

4428-
const fixture = createRoot(router, RootCmp);
4428+
const fixture = createRoot(router, RootCmp);
44294429

4430-
router.resetConfig([{path: 'lazy', loadChildren: 'expected'}]);
4430+
router.resetConfig([{path: 'lazy', loadChildren: 'expected'}]);
44314431

4432-
router.navigateByUrl('/lazy/foo/bar');
4433-
advance(fixture);
4432+
router.navigateByUrl('/lazy/foo/bar');
4433+
advance(fixture);
44344434

4435-
const link = fixture.nativeElement.querySelector('a');
4436-
expect(link.getAttribute('href')).toEqual('/lazy/foo/bar/simple');
4437-
})));
4435+
const link = fixture.nativeElement.querySelector('a');
4436+
expect(link.getAttribute('href')).toEqual('/lazy/foo/bar/simple');
4437+
})));
44384438

4439-
fixmeIvy('unknown').it(
4440-
'should ignore empty path when in corrected mode',
4441-
fakeAsync(inject(
4442-
[Router, NgModuleFactoryLoader],
4443-
(router: Router, loader: SpyNgModuleFactoryLoader) => {
4444-
router.relativeLinkResolution = 'corrected';
4445-
loader.stubbedModules = {expected: LazyLoadedModule};
4439+
fixmeIvy('FW-887: JIT: compilation of NgModule')
4440+
.it('should ignore empty path when in corrected mode',
4441+
fakeAsync(inject(
4442+
[Router, NgModuleFactoryLoader],
4443+
(router: Router, loader: SpyNgModuleFactoryLoader) => {
4444+
router.relativeLinkResolution = 'corrected';
4445+
loader.stubbedModules = {expected: LazyLoadedModule};
44464446

4447-
const fixture = createRoot(router, RootCmp);
4447+
const fixture = createRoot(router, RootCmp);
44484448

4449-
router.resetConfig([{path: 'lazy', loadChildren: 'expected'}]);
4449+
router.resetConfig([{path: 'lazy', loadChildren: 'expected'}]);
44504450

4451-
router.navigateByUrl('/lazy/foo/bar');
4452-
advance(fixture);
4451+
router.navigateByUrl('/lazy/foo/bar');
4452+
advance(fixture);
44534453

4454-
const link = fixture.nativeElement.querySelector('a');
4455-
expect(link.getAttribute('href')).toEqual('/lazy/foo/simple');
4456-
})));
4454+
const link = fixture.nativeElement.querySelector('a');
4455+
expect(link.getAttribute('href')).toEqual('/lazy/foo/simple');
4456+
})));
44574457
});
44584458
});
44594459

0 commit comments

Comments
 (0)