Skip to content

Tag Editor: contextualize database update after save #615

Closed

Description

@litemotiv

When doing a regular database update from a subdirectory, only the current directory will be processed, which results in quick update. When editing tags a full database update follows which takes significantly longer.

To Reproduce

Regular / expected behaviour:

  • Go to a an album subdirectory and press u
  • Contextual database update starts and finishes quickly

When tag editing:

  • Edit one or more tags in an album directory and press save
  • Full database update starts and takes long to finish

The desired behaviour is that saving tags also initiates a local / contextual update only for the current (sub)directory.

Tested on 0.9.2.

Activity

  1. arybczak commented on Oct 23, 2024

    @arybczak
    Collaborator

    This should work as expected on 0.10, please reopen if this is not the case.

  2. m040601 commented on Mar 28, 2025

    @m040601
      ..., please reopen if this is not the case.              >
    

    This is happening to me too and it is becoming painfull as my music collection
    has reached 100k tracks.

    Full database update starts and takes long to finish >
    I am on Archlinux,

    Name            : ncmpcpp
    Version         : 0.10.1-3
    Architecture    : x86_64
    Depends On      : curl  libcurl.so=4-64  libmpdclient  libmpdclient.so=2-64  fftw  libfftw3.so=3-64  boost-libs  libboost_filesystem.so=1.87.0-64  libboost_locale.so=1.87.0-64  libboost_program_options.so=1.87.0-64  libboost_thread.so=1.87.0-64  icu  libicui18n.so=76-64  libicuuc.so=76-64  glibc  gcc-libs  ncurses  libncursesw.so=6-64  readline  libreadline.so=8-64  taglib
    Installed Size  : 2.56 MiB
    Packager        : T.J. Townsend <[email protected]>
    Build Date      : Thu 06 Feb 2025 04:18:37 PM WET
    Install Date    : Thu 20 Feb 2025 02:59:37 PM WET
    

    When ?

    1. pressing 6, go to tag editor.

    2. There are 3 columns, "Directories", "Tag types", "Tags

    3. Do you editing

    4. The tags change and the column "Tags" is marked with "<".

    5. To confirm the changes press "y".

    I would expect only a "contextual update" to happen. Instead a full database update starts and take too long to finish.

  3. litemotiv commented on Mar 28, 2025

    @litemotiv
    Author

    This should work as expected on 0.10, please reopen if this is not the case.

    I'm currently on 0.10.1 and it appears that it is not working as intended yet. Editing tags and saving still results in a full database update.

    Please let me know if you need any other information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions