code review re advanced settings + added popupFontSize

gorhill · gorhill · commit ee4fc2aed68b · 2016-11-06T16:27:21.000-05:00
diff --git a/src/js/background.js b/src/js/background.js
@@ -73,6 +73,7 @@ return {
     hiddenSettingsDefault: {
         ignoreRedirectFilters: false,
         ignoreScriptInjectFilters: false,
+        popupFontSize: 'unset',
         suspendTabsUntilReady: false
     },
     // This will be filled ASAP:
diff --git a/src/js/messaging.js b/src/js/messaging.js
@@ -282,8 +282,8 @@ var getFirewallRules = function(srcHostname, desHostnames) {
 /******************************************************************************/
 
 var popupDataFromTabId = function(tabId, tabTitle) {
-    var tabContext = &micro;b.tabContextManager.mustLookup(tabId);
-    var rootHostname = tabContext.rootHostname;
+    var tabContext = &micro;b.tabContextManager.mustLookup(tabId),
+        rootHostname = tabContext.rootHostname;
     var r = {
         advancedUserEnabled: &micro;b.userSettings.advancedUserEnabled,
         appName: vAPI.app.name,
@@ -294,6 +294,7 @@ var popupDataFromTabId = function(tabId, tabTitle) {
         firewallPaneMinimized: &micro;b.userSettings.firewallPaneMinimized,
         globalAllowedRequestCount: &micro;b.localSettings.allowedRequestCount,
         globalBlockedRequestCount: &micro;b.localSettings.blockedRequestCount,
+        fontSize: &micro;b.hiddenSettings.popupFontSize,
         netFilteringSwitch: false,
         rawURL: tabContext.rawURL,
         pageURL: tabContext.normalURL,
diff --git a/src/js/popup.js b/src/js/popup.js
@@ -29,6 +29,11 @@
 
 /******************************************************************************/
 
+var popupFontSize = vAPI.localStorage.getItem('popupFontSize');
+if ( typeof popupFontSize === 'string' && popupFontSize !== 'unset' ) {
+    document.body.style.setProperty('font-size', popupFontSize);
+}
+
 // Ensure the popup is properly sized as soon as possible. It is assume the DOM
 // content is ready at this point, which should be the case given where this
 // script file is included in the HTML file.
@@ -100,7 +105,6 @@ var rowsToRecycle = uDom();
 var cachedPopupHash = '';
 var statsStr = vAPI.i18n('popupBlockedStats');
 var domainsHitStr = vAPI.i18n('popupHitDomainCount');
-var reNetworkRelatedURL = /^(?:ftps?|https?|wss?):\/\//;
 
 /******************************************************************************/
 
@@ -386,6 +390,17 @@ var renderPrivacyExposure = function() {
 // Assume everything has to be done incrementally.
 
 var renderPopup = function() {
+    if ( popupData.fontSize !== popupFontSize ) {
+        popupFontSize = popupData.fontSize;
+        if ( popupFontSize !== 'unset' ) {
+            document.body.style.setProperty('font-size', popupFontSize);
+            vAPI.localStorage.setItem('popupFontSize', popupFontSize);
+        } else {
+            document.body.style.removeProperty('font-size');
+            vAPI.localStorage.removeItem('popupFontSize');
+        }
+    }
+
     if ( popupData.tabTitle ) {
         document.title = popupData.appName + ' - ' + popupData.tabTitle;
     }
diff --git a/src/js/start.js b/src/js/start.js
@@ -282,18 +282,23 @@ var onAdminSettingsRestored = function() {
 /******************************************************************************/
 
 &micro;b.hiddenSettings = (function() {
-    var json = vAPI.localStorage.getItem('hiddenSettings');
+    var out = objectAssign({}, &micro;b.hiddenSettingsDefault),
+        json = vAPI.localStorage.getItem('hiddenSettings');
     if ( typeof json === 'string' ) {
         try {
-            var out = JSON.parse(json);
-            if ( out instanceof Object ) {
-                return out;
+            var o = JSON.parse(json);
+            if ( o instanceof Object ) {
+                for ( var k in o ) {
+                    if ( out.hasOwnProperty(k) ) {
+                        out[k] = o[k];
+                    }
+                }
             }
         }
         catch(ex) {
         }
     }
-    return objectAssign({}, &micro;b.hiddenSettingsDefault);
+    return out;
 })();
 
 /******************************************************************************/
diff --git a/src/js/storage.js b/src/js/storage.js
@@ -101,6 +101,9 @@
                 out[name] = false;
             }
             break;
+        case 'string':
+            out[name] = value;
+            break;
         default:
             break;
         }

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,9 @@`
`101`	`101`	`out[name] = false;`
`102`	`102`	`}`
`103`	`103`	`break;`
	`104`	`+ case 'string':`
	`105`	`+ out[name] = value;`
	`106`	`+ break;`
`104`	`107`	`default:`
`105`	`108`	`break;`
`106`	`109`	`}`