Skip to content

Commit b61fb33

Browse files
committed
fix the undue discarding of logger events in edge cases
1 parent b23a0e9 commit b61fb33

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

src/js/logger-ui.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -546,8 +546,8 @@ var renderLogEntry = function(entry) {
546546
}
547547

548548
rowFilterer.filterOne(tr, true);
549-
550549
tbody.insertBefore(tr, tbody.firstChild);
550+
return tr;
551551
};
552552

553553
/******************************************************************************/
@@ -565,14 +565,16 @@ var renderLogEntries = function(response) {
565565

566566
var tabIds = response.tabIds;
567567
var n = entries.length;
568-
var entry;
568+
var entry, tr;
569569
for ( var i = 0; i < n; i++ ) {
570570
entry = entries[i];
571-
// Unlikely, but it may happen
571+
tr = renderLogEntry(entries[i]);
572+
// https://github.com/gorhill/uBlock/issues/1613#issuecomment-217637122
573+
// Unlikely, but it may happen: mark as void if associated tab no
574+
// longer exist.
572575
if ( entry.tab && tabIds.hasOwnProperty(entry.tab) === false ) {
573-
continue;
576+
tr.classList.remove('canMtx');
574577
}
575-
renderLogEntry(entries[i]);
576578
}
577579

578580
// Prevent logger from growing infinitely and eating all memory. For

0 commit comments

Comments
 (0)