code review for gorhill@0322d03303cd -- fix handling of rc versions

gorhill · gorhill · commit b5ef2d0105d6 · 2018-09-11T08:42:02.000-04:00
diff --git a/src/js/start.js b/src/js/start.js
@@ -144,7 +144,7 @@ var onVersionReady = function(lastVersion) {
             } else if ( pstr.startsWith('.') || pstr.startsWith('b') ) {
                 pint = parseInt(pstr.slice(1), 10);
             } else if ( pstr.startsWith('rc') ) {
-                pint = parseInt(pstr.slice(2), 10) * 100;
+                pint = parseInt(pstr.slice(2), 10) + 100;
             } else {
                 pint = parseInt(pstr, 10);
             }
@@ -153,14 +153,16 @@ var onVersionReady = function(lastVersion) {
         return vint;
     };
 
-    if ( intFromVersion(lastVersion) <= 1016021007 ) {
+    let lastVersionInt = intFromVersion(lastVersion);
+
+    if ( lastVersionInt <= 1016021007 ) {
         &micro;b.sessionSwitches.toggle('no-scripting', 'behind-the-scene', 2);
         &micro;b.permanentSwitches.toggle('no-scripting', 'behind-the-scene', 2);
         &micro;b.saveHostnameSwitches();
     }
 
     // https://github.com/uBlockOrigin/uBlock-issues/issues/212#issuecomment-419741324
-    if ( intFromVersion(lastVersion) <= 1015024000 ) {
+    if ( lastVersionInt <= 1015024000 ) {
         if ( &micro;b.hiddenSettings.manualUpdateAssetFetchPeriod === 2000 ) {
             &micro;b.hiddenSettings.manualUpdateAssetFetchPeriod = 500;
             &micro;b.saveHiddenSettings();
