code review of 7713597 (oops)

gorhill · gorhill · commit 9b8303378519 · 2017-10-13T09:38:16.000-04:00
diff --git a/src/js/tab.js b/src/js/tab.js
@@ -177,7 +177,7 @@ housekeep itself.
             //   If the trigger is a change in the opener's URL, mark the entry
             //   as candidate for popunder filtering.
             if ( targetTabId === entry.opener.tabId ) {
-                entry.popunder = true;
+                entry.opener.popunder = true;
             }
             if ( vAPI.tabs.onPopupUpdated(tabId, entry.opener) === true ) {
                 entry.destroy();

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ housekeep itself.`
`177`	`177`	`// If the trigger is a change in the opener's URL, mark the entry`
`178`	`178`	`// as candidate for popunder filtering.`
`179`	`179`	`if ( targetTabId === entry.opener.tabId ) {`
`180`		`- entry.popunder = true;`
	`180`	`+ entry.opener.popunder = true;`
`181`	`181`	`}`
`182`	`182`	`if ( vAPI.tabs.onPopupUpdated(tabId, entry.opener) === true ) {`
`183`	`183`	`entry.destroy();`