make cloud storage support optional

gorhill · gorhill · commit 2e953b45c969 · 2016-10-16T13:04:31.000-04:00
(currently not supported on FF-webext and MS Edge)
diff --git a/src/css/dashboard-common.css b/src/css/dashboard-common.css
@@ -37,7 +37,9 @@ div > p:last-child {
 input[type="number"] {
     width: 5em;
     }
-
+input[type="checkbox"][disabled] + label {
+    opacity: 0.4;
+    }
 .para {
     width: 40em;
     }
diff --git a/src/js/messaging.js b/src/js/messaging.js
@@ -648,16 +648,18 @@ vAPI.messaging.listen('elementPicker', onMessage);
 
 /******************************************************************************/
 
-var &micro;b = &micro;Block;
-
-/******************************************************************************/
-
 var onMessage = function(request, sender, callback) {
+    // Cloud storage support is optional.
+    if ( vAPI.cloud instanceof Object === false ) {
+        callback();
+        return;
+    }
+
     // Async
     switch ( request.what ) {
     case 'cloudGetOptions':
         vAPI.cloud.getOptions(function(options) {
-            options.enabled = &micro;b.userSettings.cloudStorageEnabled === true;
+            options.enabled = &micro;Block.userSettings.cloudStorageEnabled === true;
             callback(options);
         });
         return;
@@ -722,7 +724,8 @@ var getLocalData = function(callback) {
             lastRestoreFile: o.lastRestoreFile,
             lastRestoreTime: o.lastRestoreTime,
             lastBackupFile: o.lastBackupFile,
-            lastBackupTime: o.lastBackupTime
+            lastBackupTime: o.lastBackupTime,
+            cloudStorageSupported: vAPI.cloud instanceof Object
         });
     };
 
diff --git a/src/js/settings.js b/src/js/settings.js
@@ -138,6 +138,10 @@ var onLocalDataReceived = function(details) {
         uDom('#localData > ul > li:nth-of-type(3) > ul > li:nth-of-type(2)').text(lastRestoreFile);
         uDom('#localData > ul > li:nth-of-type(3)').css('display', '');
     }
+
+    if ( details.cloudStorageSupported === false ) {
+        uDom('#cloud-storage-enabled').attr('disabled', '');
+    }
 };
 
 /******************************************************************************/
diff --git a/src/js/start.js b/src/js/start.js
@@ -67,12 +67,15 @@ var onAllReady = function() {
     // for launch time.
     &micro;b.assets.remoteFetchBarrier -= 1;
 
-    vAPI.cloud.start([
-        'tpFiltersPane',
-        'myFiltersPane',
-        'myRulesPane',
-        'whitelistPane'
-    ]);
+    // vAPI.cloud is optional.
+    if ( vAPI.cloud instanceof Object ) {
+        vAPI.cloud.start([
+            'tpFiltersPane',
+            'myFiltersPane',
+            'myRulesPane',
+            'whitelistPane'
+        ]);
+    }
 
     //quickProfiler.stop(0);
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,9 @@ div > p:last-child {`
`37`	`37`	`input[type="number"] {`
`38`	`38`	`width: 5em;`
`39`	`39`	`}`
`40`		`-`
	`40`	`+input[type="checkbox"][disabled] + label {`
	`41`	`+ opacity: 0.4;`
	`42`	`+ }`
`41`	`43`	`.para {`
`42`	`44`	`width: 40em;`
`43`	`45`	`}`