Skip to content

Commit 2da91b8

Browse files
committed
use plain version string: uBO will render itself to b/rc if needed
1 parent 30eb2cb commit 2da91b8

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

tools/make-firefox-meta.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,15 @@
2121
firefox_manifest = json.load(f2)
2222

2323
match = re.search('^(\d+\.\d+\.\d+)(\.\d+)$', version)
24-
if match:
25-
buildtype = int(match.group(2)[1:])
26-
if buildtype < 100:
27-
builttype = 'b' + str(buildtype)
28-
else:
29-
builttype = 'rc' + str(buildtype - 100)
30-
firefox_manifest['version'] = match.group(1) + builttype
31-
else:
32-
firefox_manifest['version'] = version
24+
if not match:
3325
# https://bugzilla.mozilla.org/show_bug.cgi?id=1459007
3426
# By design Firefox opens the sidebar with new installation of
3527
# uBO when sidebar_action is present in the manifest.
3628
# Remove sidebarAction support for stable release of uBO.
3729
del firefox_manifest['sidebar_action']
3830

31+
firefox_manifest['version'] = version
32+
3933
with open(firefox_manifest_file, 'w') as f2:
4034
json.dump(firefox_manifest, f2, indent=2, separators=(',', ': '), sort_keys=True)
4135
f2.write('\n')

0 commit comments

Comments
 (0)