Feature/admin forth/1259/add delete many to dataapi#502
Open
Feature/admin forth/1259/add delete many to dataapi#502
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a deleteMany method to AdminForth's data API layer, enabling bulk deletion of records by primary key across all supported database connectors (SQLite, PostgreSQL, MySQL, MongoDB, ClickHouse).
Changes:
- Added
deleteManymethod to all five data connectors (SQLite, PostgreSQL, MySQL, MongoDB, ClickHouse) and to the type interfaces (IAdminForthDataSourceConnectorBase,IOperationalResource). - Added a new
adminforth-auto-removeplugin reference in the dev-demo Taskfile.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| adminforth/types/Back.ts | Adds deleteMany to connector and operational resource interfaces |
| adminforth/dataConnectors/sqlite.ts | Implements deleteMany using parameterized ? placeholders |
| adminforth/dataConnectors/postgres.ts | Implements deleteMany using $N placeholders |
| adminforth/dataConnectors/mysql.ts | Implements deleteMany using ? placeholders |
| adminforth/dataConnectors/mongo.ts | Implements deleteMany using $in operator |
| adminforth/dataConnectors/clickhouse.ts | Implements deleteMany with string-interpolated IDs |
| dev-demo/Taskfile.yaml | Adds adminforth-auto-remove to the plugins list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a deleteMany method to the data API layer, enabling bulk deletion of records by primary key across all five database connectors (SQLite, PostgreSQL, MySQL, MongoDB, ClickHouse). It also registers a new adminforth-auto-remove plugin in the dev-demo task configuration.
Changes:
- Added
deleteManyimplementations to all five data connectors (sqlite, postgres, mysql, mongo, clickhouse) for batch deletion by record IDs. - Declared
deleteManyas an optional method on theIOperationalResourceinterface inBack.ts. - Added
adminforth-auto-removeto the dev-demo plugin list.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| adminforth/types/Back.ts | Added optional deleteMany to IOperationalResource interface |
| adminforth/dataConnectors/sqlite.ts | New deleteMany using parameterized IN (?) query |
| adminforth/dataConnectors/postgres.ts | New deleteMany using parameterized IN ($1, $2, ...) query |
| adminforth/dataConnectors/mysql.ts | New deleteMany using parameterized IN (?) query |
| adminforth/dataConnectors/mongo.ts | New deleteMany using $in operator |
| adminforth/dataConnectors/clickhouse.ts | New deleteMany using ALTER TABLE ... DELETE WHERE with named params |
| dev-demo/Taskfile.yaml | Added adminforth-auto-remove to plugins list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| query: `ALTER TABLE ${this.dbName}.${resource.table} DELETE WHERE ${conditions}`, | ||
| query_params: queryParams, | ||
| }); | ||
| return recordIds.length ?? 0; |
Comment on lines
+1763
to
+1764
|
|
||
| deleteMany?(recordIds: any[]): Promise<number>; |
Comment on lines
+1763
to
+1764
|
|
||
| deleteMany?(recordIds: any[]): Promise<number>; |
Comment on lines
+385
to
+390
| async deleteMany({ resource, recordIds }: { resource: AdminForthResource, recordIds: any[] }): Promise<number> { | ||
| const placeholders = recordIds.map(() => '?').join(','); | ||
| const q = this.client.prepare(`DELETE FROM ${resource.table} WHERE ${this.getPrimaryKey(resource)} IN (${placeholders})`); | ||
| const res = await q.run(...recordIds); | ||
| return res.changes ?? 0; | ||
| } |
Comment on lines
+458
to
+463
| async deleteMany({ resource, recordIds }: { resource: AdminForthResource; recordIds: any[] }): Promise<number> { | ||
| const placeholders = recordIds.map((_, idx) => `$${idx + 1}`).join(', '); | ||
| const query = `DELETE FROM "${resource.table}" WHERE "${this.getPrimaryKey(resource)}" IN (${placeholders})`; | ||
| const res = await this.client.query(query, recordIds); | ||
| return res.rowCount ?? 0; | ||
| } |
Comment on lines
+423
to
+428
| async deleteMany({ resource, recordIds }: { resource: AdminForthResource; recordIds: any[] }): Promise<number> { | ||
| const placeholders = recordIds.map(() => '?').join(','); | ||
| const query = `DELETE FROM ${resource.table} WHERE ${this.getPrimaryKey(resource)} IN (${placeholders})`; | ||
| const [result] = await this.client.execute(query, recordIds); | ||
| return result.affectedRows ?? 0; | ||
| } |
Comment on lines
+400
to
+404
| async deleteMany({ resource, recordIds }: { resource: AdminForthResource; recordIds: any[] }): Promise<number> { | ||
| const collection = this.client.db().collection(resource.table); | ||
| const res = await collection.deleteMany({[this.getPrimaryKey(resource)]: { $in: recordIds }}); | ||
| return res.deletedCount ?? 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.