Skip to content

Commit e7dd5bd

Browse files
author
jbachorik
committed
need to resolve the TypeMirror for any method call; not only Service.*
1 parent 2acb847 commit e7dd5bd

2 files changed

Lines changed: 8 additions & 10 deletions

File tree

‎make/build.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@
294294
</copy>
295295
</target>
296296

297-
<target name="build-traces" depends="jar">
297+
<target name="build-traces" depends="jar, compile-tests">
298298
<echo>executing ${bin.dir}/${btracec} -cp ${build.dir}/test -d ${tests.dir} ${traces.dir}/*.java</echo>
299299
<apply executable="${bin.dir}/${btracec}" verbose="true" failonerror="true">
300300
<fileset dir="${traces.dir}" includes="**/*.java"/>

‎src/share/classes/com/sun/btrace/compiler/VerifierVisitor.java‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -95,17 +95,15 @@ public Boolean visitMethodInvocation(MethodInvocationTree node, Void v) {
9595
if (xt.getKind() == Tree.Kind.MEMBER_SELECT) {
9696
MemberSelectTree mst = (MemberSelectTree)xt;
9797
xt = mst.getExpression();
98-
if (xt.toString().endsWith("Service")) {
99-
TypeMirror tm = getType(xt);
100-
if (verifier.getTypeUtils().isSubtype(tm, serviceInjectorTm)) {
101-
if (validateInjectionParams(node)) {
102-
return super.visitMethodInvocation(node, v);
103-
} else {
104-
return reportError("service.injector.literals", node);
105-
}
106-
} else if (verifier.getTypeUtils().isSubtype(tm, btraceServiceTm)) {
98+
TypeMirror tm = getType(xt);
99+
if (verifier.getTypeUtils().isSubtype(tm, serviceInjectorTm)) {
100+
if (validateInjectionParams(node)) {
107101
return super.visitMethodInvocation(node, v);
102+
} else {
103+
return reportError("service.injector.literals", node);
108104
}
105+
} else if (verifier.getTypeUtils().isSubtype(tm, btraceServiceTm)) {
106+
return super.visitMethodInvocation(node, v);
109107
}
110108
}
111109

0 commit comments

Comments
 (0)