fix(missioncontrol): same-column drag no-op — restore client-side guards#6
Merged
developdaly merged 4 commits intoMar 25, 2026
Merged
Conversation
…drop handler and moveCard helper
…c-multimedia-card-descriptions
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores two client-side same-column no-op guards in
missioncontrol/src/ui.tsthat were inadvertently dropped during the multimedia card attachment branch. Dragging a card within its own column no longer triggers the stage skill.Fixes:
findColumnForCard(cardId) !== colIdbefore callingmoveCardmoveCardhelper: now exits early iffindColumnForCard(cardId) === columnIdTest Coverage
13/13 tests pass (missioncontrol-same-column-noop × 3, base-path-regression × 5, column-descriptions × 2, inline-script-syntax × 1, multimedia-ui × 2)
Pre-Landing Review
No issues found. Only functional delta: 2 guard lines in existing JS functions.
Test plan
🤖 Generated with Claude Code