Universal image squash - #2028
Draft
Kaniska (v-Kaniska244) wants to merge 6 commits into
Draft
Kaniska (v-Kaniska244) wants to merge 6 commits into
Kaniska (v-Kaniska244) wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Universal retries lack the required tool setup, and the smoke assertion conflicts with the supported disable override.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds single-layer squashing for the Universal image during testing and publishing.
Changes:
- Adds configurable Universal image squashing and tag publishing.
- Installs
docker-squashin relevant workflows and validates layer count. - Bumps Universal to 6.2.0 and updates documentation.
| File | Description |
|---|---|
src/universal/README.md |
Updates 6.2 image references. |
src/universal/manifest.json |
Bumps version to 6.2.0. |
package.json |
Adds the push test script. |
build/test-push.js |
Tests squashing and push behavior. |
build/src/utils/config.js |
Adds squash configuration resolution. |
build/src/push.js |
Squashes and publishes Universal tags. |
build/config.json |
Enables Universal squashing. |
.github/workflows/smoke-universal.yaml |
Installs the squashing tool. |
.github/workflows/push.yml |
Configures release publishing. |
.github/workflows/push-manual-dev.yml |
Configures manual development publishing. |
.github/workflows/push-dev.yml |
Configures development publishing. |
.github/actions/smoke-test/test.sh |
Validates the filesystem layer count. |
.github/actions/smoke-test/build.sh |
Squashes smoke-test images. |
.github/actions/setup-docker-squash/action.yaml |
Adds reusable tool setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ], | ||
|
|
||
| "flattenBaseImage": [], | ||
| "squashUniversalImage": true, |
Comment on lines
+22
to
+26
| layer_count="$(docker image inspect --format '{{len .RootFS.Layers}}' "${id_image}")" | ||
| if [[ "${layer_count}" -ne 1 ]]; then | ||
| echo "Universal image has ${layer_count} filesystem layers; expected 1." | ||
| exit 1 | ||
| fi |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.