Open
Conversation
focus was set to menu_cover on menu open but never restore on hide (say after performing a File->Delete); on Xwayland RevertToPointerRoot doesn't recover it; added an explicit call to XSetInputFocus back to fehwin->win before destroying the cover window.
… times when pressing the zoom or pan keys, the zoom or pan will appear to be ignored or in the wrong direction. User experience is a very random experience. Two related fixes: 1. Preserve zoom and pan across ConfigureNotify events (it seems the Wayland compositor sends these events at unexpected times, triggering the had_resize code path and resetting zoom/recentering the image and clobbering the user's intent. Added a manual_zoom flag to winwidget, set on user zoom input and cleared on image load. When this flag is set, skip the zoom/position reset in the had_resize block. 2. Force an immediate frame presentation after each render since Wayland batches XSetWindowBackgroundPixmap/XClearWindow requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG REPORT: At random times when pressing the zoom or pan keys, the zoom or pan will appear to be ignored or in the wrong direction. User experience is a very random.
Preserve zoom and pan across ConfigureNotify events (it seems the Wayland compositor sends these events at unexpected times, triggering the had_resize code path and resetting zoom/recentering the image and clobbering the user's intent. Added a manual_zoom flag to winwidget, set on user zoom input and cleared on image load. When this flag is set, skip the zoom/position reset in the had_resize block.
Force an immediate frame presentation after each render since Wayland batches XSetWindowBackgroundPixmap/XClearWindow requests.