print warning if actual triton cache dir is on NFS, not just for default - #6487
Merged
loadams merged 1 commit intoSep 4, 2024
Merged
Conversation
tjruwase
requested review from
tohtana
and removed request for
arashb and
awan-10
September 4, 2024 15:18
Collaborator
|
@jrandall Thank you for the contribution! |
tohtana
approved these changes
Sep 4, 2024
loadams
approved these changes
Sep 4, 2024
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Mar 20, 2025
…ult (deepspeedai#6487) move the logic that prints a warning when triton cache dir is on NFS to act on the actual calculated cache_dir rather than on the default. this means that: - when the default directory (in the user's home directory) is on NFS but `TRITON_CACHE_DIR` is set to a non-NFS directory, no warning will be printed whereas prior to this change a spurious and confusing warning was printed - when the user's home directory is not on NFS but `TRITON_CACHE_DIR` is set to an NFS directory, a warning will be printed whereas prior to this change no warning would be printed fixes deepspeedai#6486
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move the logic that prints a warning when triton cache dir is on NFS to act on the actual calculated cache_dir rather than on the default.
this means that:
TRITON_CACHE_DIRis set to a non-NFS directory, no warning will be printed whereas prior to this change a spurious and confusing warning was printedTRITON_CACHE_DIRis set to an NFS directory, a warning will be printed whereas prior to this change no warning would be printedfixes #6486