Skip to content

fix(@deepnote/reactivity): remove agent block#340

Merged
dinohamzic merged 1 commit intomainfrom
fix-remove-agent-block-ast-analyzer
Mar 11, 2026
Merged

fix(@deepnote/reactivity): remove agent block#340
dinohamzic merged 1 commit intomainfrom
fix-remove-agent-block-ast-analyzer

Conversation

@dinohamzic
Copy link
Contributor

@dinohamzic dinohamzic commented Mar 11, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores

    • Downgraded package version from 1.2.1 to 1.2.0

  • Tests

    • Removed test case for agent block type handling

  • Changes

    • Removed support for agent block types from the analyzer

@dinohamzic dinohamzic self-assigned this Mar 11, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Version downgrade from 1.2.1 to 1.2.0 in package.json. Removed 'agent' from the supported cell types list in the AST analyzer. Deleted corresponding test case that verified agent blocks were handled without crashing. No functional logic altered beyond narrowing the supported block types.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Updates Docs ⚠️ Warning Agent block support was removed without documentation updates, CHANGELOG entry, or deprecation notice. Add CHANGELOG entry, update README.md documentation, and verify deepnote-internal repo reflects this breaking change.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing agent block support from the reactivity package's AST analyzer, which aligns with deletions in the code and test files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 11, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.49%. Comparing base (6dd0d02) to head (ec06c2c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files         124      124           
  Lines        7375     7375           
  Branches     1985     1985           
=======================================
  Hits         6158     6158           
  Misses       1217     1217

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai bot requested changes Mar 11, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/reactivity/package.json`:
- Line 3: The package.json version was incorrectly downgraded to "1.2.0"; update
the "version" field in packages/reactivity/package.json to "1.2.2" (instead of
1.2.1) so versions increase monotonically and downstream consumers using ^1.2.1
get the fix; also ensure any accompanying lockfiles or release metadata
referencing packages/reactivity's version are updated to match.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cb1b2f60-c9f6-47d1-9c3c-e3af0a0bda2d

📥 Commits

Reviewing files that changed from the base of the PR and between 6dd0d02 and ec06c2c.

📒 Files selected for processing (3)
  • packages/reactivity/package.json
  • packages/reactivity/src/ast-analyzer.test.ts
  • packages/reactivity/src/ast-analyzer.ts
💤 Files with no reviewable changes (2)
  • packages/reactivity/src/ast-analyzer.test.ts
  • packages/reactivity/src/ast-analyzer.ts

@dinohamzic dinohamzic marked this pull request as ready for review March 11, 2026 12:07
@dinohamzic dinohamzic requested a review from a team as a code owner March 11, 2026 12:07
@dinohamzic dinohamzic requested a review from saltenasl March 11, 2026 12:07
@dinohamzic dinohamzic merged commit 770f211 into main Mar 11, 2026
19 of 21 checks passed
@dinohamzic dinohamzic deleted the fix-remove-agent-block-ast-analyzer branch March 11, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saltenasl saltenasl saltenasl approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@dinohamzic dinohamzic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dinohamzic @saltenasl