🛡️ Sentinel: [CRITICAL] Fix XSS vulnerability in Markdown parsing - #8
🛡️ Sentinel: [CRITICAL] Fix XSS vulnerability in Markdown parsing#8ddqd wants to merge 1 commit into
Conversation
Co-authored-by: ddqd <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Missing HTML sanitization on parsed Markdown output before injection into the DOM (
innerHTML) inpackages/webandpackages/desktop.🎯 Impact: Attackers could inject malicious scripts resulting in Cross-Site Scripting (XSS).
🔧 Fix: Installed
isomorphic-dompurifyand wrapped parsed Markdown outputs withDOMPurify.sanitize().✅ Verification: Ensure tests pass and the Markdown string outputs are properly sanitized of harmful HTML tags.
PR created automatically by Jules for task 3568245332575684866 started by @ddqd