🛡️ Sentinel: [CRITICAL] Fix command injection in macOS clipboard copy - #1
🛡️ Sentinel: [CRITICAL] Fix command injection in macOS clipboard copy#1ddqd wants to merge 1 commit into
Conversation
Co-authored-by: ddqd <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Command injection in
clipboard.ts. When copying text to the clipboard on macOS usingosascript, the text was concatenated into the command string. While"and\were escaped, an attacker could supply\r(carriage return) followed bydo shell script "..."to break out of the string and execute arbitrary shell commands.🎯 Impact: Arbitrary code execution if an attacker can control the text that is copied to the clipboard.
🔧 Fix: Switched from
osascripttopbcopyon macOS.pbcopysecurely reads the text directly from standard input instead of taking it as a command-line argument, entirely eliminating the command injection vulnerability. Also removed the unsafe shell-escaping logic for macOS since standard input doesn't need to be escaped.✅ Verification: Ran
bun testinpackages/tui. Validated thatpbcopyis correctly invoked on macOS for copying text.PR created automatically by Jules for task 16555650838689940054 started by @ddqd