Change source of truth for types to umd/index.d.ts to resolve issue with typescript import in 5.x (Resolves #109)#130
Conversation
…sue with typescript import in 5.x
SimplyLinn
changed the title
|
@dcodeIO hello! Could you review the PR? |
|
Have ya'll verified that the proposed change indeed works for both ESM and CJS/UMD? |
|
@dcodeIO we're trying to move a project from CJS to ESM, and it looks like if we swap the imports like in this PR, it works in both CJS and ESM. |
|
Would love to get this merged! 🙏 |
|
Also would love to get this merged. Requires we enable |
|
@dcodeIO Were you able to review this? We need this fix. I have tested it as well and it works fine. |
|
Any news ? |
… removed if dcodeIO/long.js#130 ever gets merged.
… removed if dcodeIO/long.js#130 ever gets merged.
|
Can we merge this one @dcodeIO? |
|
@dcodeIO Can we please get this merged? |
|
@dcodeIO Can we please get this merged? I had to use |
|
Also still having this issue. Don't want to have to set |
|
I think this change may still require |
14 participants
The previous PR to resolve this issue (#124) ended up duplicating the types to the umd module.
Moving the source-of-truth to the
./umd/index.d.tsfile enables the./index.d.tsfile to import the class from the umd subdirectory with no issues. The other way around, however, seems to be the cause of the issues.My suggestion is to move the source of truth to the umd declaration file, and import it from the root index.d.ts, as to avoid duplicated code, while still keeping the types functional.
This would resolve #109