lower test coverage threshold - #47

• Reduce CI coverage failure threshold to unblock merges while coverage improves.
• Keep pytest-cov reporting unchanged; only adjust the fail-under gate.

The following are alternative approaches to this PR:

1. Keep 90% and add/extend tests

• ➕ Maintains a higher quality bar and prevents coverage regression
• ➖ May delay merges if coverage improvements take time

2. Use differential coverage gating (changed-lines / diff coverage)

• ➕ Prevents new code from reducing coverage while allowing legacy gaps
• ➖ Adds tooling/config complexity; may require additional CI setup

3. Temporary threshold reduction with a scheduled ratchet back up

• ➕ Unblocks short-term while ensuring the threshold is restored
• ➖ Requires follow-up tracking/enforcement to avoid becoming permanent

Recommendation: If the intent is short-term unblocking, lowering to 80% is acceptable, but it should be paired with an explicit follow-up plan (issue/ticket) to ratchet the threshold back up or move to diff-based coverage gating to avoid long-term erosion.

Other (1) +1 / -1

cicd.ymlLower pytest-cov fail-under threshold to 80% +1/-1

Lower pytest-cov fail-under threshold to 80%

• Updates the CI test command to fail the workflow only when coverage drops below 80% instead of 90%. Coverage collection and term-missing reporting remain the same.

.github/workflows/cicd.yml

Description

The CI test job lowers pytest's enforced minimum coverage from 90% to 80% via --cov-fail-under,
making it easier for lower-tested changes to pass this workflow. If this workflow is used as a
required status check, it directly reduces the test-quality bar for merging; otherwise it still
reduces the reliability of CI feedback.

Code

.github/workflows/cicd.yml[31]

+          pytest -q --cov=Algorithms --cov-report=term-missing --cov-fail-under=80

Relevance

⭐⭐⭐ High

PR #43 explicitly raised CI to fail-under=90 to enforce coverage; team likely rejects weakening to
80.

PR-#43

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The workflow explicitly enforces coverage in the test job, and the PR reduces that enforcement
value, lowering the minimum required coverage for this CI job to succeed.

.github/workflows/cicd.yml[3-8]
.github/workflows/cicd.yml[29-32]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The CI workflow's coverage quality gate was reduced from 90% to 80%, which weakens the minimum test coverage enforced by CI.

## Issue Context
This change affects every run of the `test` job in `.github/workflows/cicd.yml`.

## Fix Focus Areas
- .github/workflows/cicd.yml[29-32]

## Expected fix
- Revert `--cov-fail-under` back to `90` (or to the previously agreed standard), and if the lower threshold is temporary, add an explicit tracked plan (e.g., a follow-up PR restoring 90% by a deadline) rather than weakening the gate indefinitely.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools