Skip to content

editable install toml #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dchou1618 merged 2 commits into from
Jun 19, 2026
Merged

editable install toml #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c6b4da
editable install , toml
dchou1618 Jun 19, 2026
ece67f1
include llms find
dchou1618 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/cicd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,9 @@ jobs:
run: |
python -m pip install --upgrade pip
python -m pip install -r requirements-dev.txt
python -m pip install -e .

- name: Run tests
env:
PYTHONPATH: ${{ github.workspace }}
run: pytest -q

build_and_push:
Expand Down
19 changes: 19 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
[build-system]
requires = ["setuptools>=61.0", "wheel"]
build-backend = "setuptools.build_meta"

[project]
name = "python-examples"
version = "0.1.0"
description = "Algorithms and systems examples repo"
readme = "README.md"
requires-python = ">=3.8"

dependencies = []

Comment on lines +5 to +13

@qodo-code-review qodo-code-review Bot Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Runtime deps not declared 🐞 Bug ☼ Reliability

The project metadata sets dependencies = [], but repository code imports pydantic, so a plain
pip install -e . (or wheel install) will produce an environment where imports fail unless users
separately install dependencies. This makes the new pyproject-based install path unreliable.
Agent Prompt 
## Issue description
`pyproject.toml` declares no runtime dependencies, but project modules import third-party libraries (e.g., `pydantic`). Installing the project via pip will not pull these in, causing runtime import errors in fresh environments.

## Issue Context
CI currently installs `requirements-dev.txt` (which includes `pydantic`), masking the packaging problem; users/installations that rely on `pyproject.toml` metadata will break.

## Fix Focus Areas
- pyproject.toml[5-13]
- Algorithms/slidingWindow/longestUnique.py[1-7]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

[tool.setuptools]
package-dir = {"" = "."}

[tool.setuptools.packages.find]
where = ["."]
include = ["Algorithms*", "LLMs*"]
Loading