Skip to content

Update geomet to align with requirements.txt#1236

Merged
absurdfarce merged 1 commit intoapache:masterfrom
mysto:setup
May 29, 2025
Merged

Update geomet to align with requirements.txt#1236
absurdfarce merged 1 commit intoapache:masterfrom
mysto:setup

Conversation

@bschoening
Copy link
Copy Markdown
Contributor

also fixes some pycodestyle issues

@bschoening
Copy link
Copy Markdown
Contributor Author

@absurdfarce just a small tweak, but needed to update the Homebrew formula for Cassandra's dependencies.

@absurdfarce
Copy link
Copy Markdown
Contributor

Thanks for the ping @bschoening. I was looking at this some last night but didn't actually get it finished.

Looking over this ticket also reminded me that we need to handle the removal of distutils in 3.12. My guess is that PYTHON-1334 (the migration to pyproject.toml) will handle that as a side-effect but if setup.py is around in some capacity after that we need to fix it. I've filed PYTHON-1421 to handle that.

Comment thread setup.py
sys.stderr.write("Bypassing Cython setup requirement\n")

dependencies = ['geomet>=0.1,<0.3']
dependencies = ['geomet>=1.1']
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. This is... pretty egregious. But it's definitely the right operation; we test the driver by installing libs from requirements.txt and then running tests so that's what's known to work well. An install from setup.py definitely should match that.

@absurdfarce absurdfarce merged commit fe8e926 into apache:master May 29, 2025
@absurdfarce
Copy link
Copy Markdown
Contributor

Thanks (once again) @bschoening! That was a nice catch on the disconnect between requirements.txt and setup.py... yuck.

@eladkal
Copy link
Copy Markdown

eladkal commented Jun 30, 2025

@absurdfarce is there a planned release date for next version?
Required to fix apache/airflow#52530 in apache-airflow

@absurdfarce
Copy link
Copy Markdown
Contributor

Hey @eladkal, we don't have a scheduled date yet. We're trying to get several other driver releases out this quarter so it certainly won't be this month. That said, I'd like to see if we can get 3.30.0 out in the next quarter.. so my guess is sometime late summer.

That's very much contingent on being able to get the asyncio reactor to production quality, though, so that's certainly not a guarantee.

@absurdfarce
Copy link
Copy Markdown
Contributor

A quick update here @eladkal ... we recently announced that we're planning on getting a 3.29.3 out soon which will include the changes in this PR. There's a few more changes I'd like to squeeze into that release but I hope to have something out soon!

@absurdfarce
Copy link
Copy Markdown
Contributor

@eladkal A quick update: 3.29.3 was just released today and it does include this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants