Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes sandbox naming by renaming the local-eval and local-jupyter variants to eval and jupyter, and flattens sandbox implementation modules to top-level imports across the library, tests, examples, and docs.
Changes:
- Renames sandbox variants:
local-eval→eval,local-jupyter→jupyter(including enums, factory logic, and docs/examples/tests). - Flattens module layout by importing sandbox implementations from
code_sandboxes.{eval_sandbox,jupyter_sandbox,docker_sandbox,datalayer_sandbox}(removinglocal/andremote/package init modules). - Updates documentation site dependency (
@datalayer/primer-addons) and refreshes docs/examples to match the new naming.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_sandboxes.py | Updates deprecated aggregate tests to new variant names (eval/jupyter). |
| tests/test_models.py | Updates enum expectations for renamed variants. |
| tests/test_jupyter.py | Updates import path and env var gate wording for jupyter tests. |
| tests/test_integration.py | Updates LocalEvalSandbox import path. |
| tests/test_factory.py | Updates factory tests for renamed variants and flattened imports. |
| tests/test_eval.py | Updates LocalEvalSandbox import path and expected variant string. |
| tests/conftest.py | Updates LocalEvalSandbox import path used in fixtures. |
| examples/local_jupyter_example.py | Updates example variant string and messaging to jupyter. |
| examples/local_eval_example.py | Updates example variant string and messaging to eval. |
| examples/Makefile | Renames make targets from local-eval/local-jupyter to eval/jupyter. |
| docs/package.json | Bumps @datalayer/primer-addons dependency. |
| docs/docs/sandboxes/index.mdx | Updates docs for renamed variants and adds top-level import examples. |
| docs/docs/index.mdx | Updates variant tables to eval/jupyter. |
| docs/docs/examples/index.mdx | Updates example commands to make eval / make jupyter. |
| docs/docs/api-reference/index.mdx | Updates API reference variant strings and (attempted) default. |
| code_sandboxes/remote/init.py | Removes remote package re-exports (module layout flattening). |
| code_sandboxes/local/init.py | Removes local package re-exports (module layout flattening). |
| code_sandboxes/models.py | Renames SandboxVariant enum members/values for eval and jupyter. |
| code_sandboxes/jupyter_sandbox.py | Updates internal imports and environment metadata/variant string to jupyter. |
| code_sandboxes/eval_sandbox.py | Updates internal imports, environment metadata, and variant string to eval. |
| code_sandboxes/docker_sandbox.py | Updates internal imports to flattened module layout. |
| code_sandboxes/datalayer_sandbox.py | Updates internal imports to flattened module layout. |
| code_sandboxes/base.py | Updates factory dispatch/imports and supported variant strings. |
| code_sandboxes/init.py | Updates top-level exports/imports to flattened module layout and new variant string in doc example. |
| README.md | Updates variant table and documents new top-level module layout/imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.