fix: remove EXPRESSION column dependency in get_indexes_sql()#1437
Open
dimitri-yatsenko wants to merge 1 commit intomasterfrom
Open
fix: remove EXPRESSION column dependency in get_indexes_sql()#1437dimitri-yatsenko wants to merge 1 commit intomasterfrom
dimitri-yatsenko wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
Note: DataJoint has not yet explicitly supported functional indexes — that would be a future feature, maybe. So dropping the EXPRESSION reference doesn't lose any current functionality. |
The EXPRESSION column in information_schema.STATISTICS only exists in MySQL 8.0.13+. Add a fallback query without EXPRESSION for MySQL < 8.0.13 and MariaDB. heading.py catches the error and retries with the fallback. Fixes #1436
dimitri-yatsenko
force-pushed
the
fix/1436-indexes-expression-column
branch
from
faa6ccd to
aff54de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_indexes_sql()referenced theEXPRESSIONcolumn ininformation_schema.STATISTICS, which only exists in MySQL 8.0.13+@schemadecoration on MySQL < 8.0.13 and MariaDB withUnknown column 'EXPRESSION'COLUMN_NAMEdirectly — functional indexes (NULL column name) are already filtered out inheading.pyFixes #1436
Test plan
@schemadecoration works on MySQL 5.7 or MariaDB