fix: preserve NOT NULL constraint in migrate_columns()#1435
Merged
dimitri-yatsenko merged 1 commit intomasterfrom Apr 22, 2026
Merged
fix: preserve NOT NULL constraint in migrate_columns()#1435dimitri-yatsenko merged 1 commit intomasterfrom
dimitri-yatsenko merged 1 commit intomasterfrom
Conversation
migrate_columns() and generate_migration_sql() issued MODIFY COLUMN without NOT NULL, causing MySQL to silently default columns to nullable. Add IS_NULLABLE to information_schema queries and conditionally include NOT NULL in the generated ALTER TABLE statements. Fixes #1434 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
dimitri-yatsenko
requested review from
esutlie,
mweitzel and
ttngu207
and removed request for
mweitzel
esutlie
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrate_columns()and legacygenerate_migration_sql()issuedMODIFY COLUMNwithoutNOT NULL, causing MySQL to silently default columns to nullableIS_NULLABLEtoinformation_schema.COLUMNSqueries inanalyze_columns()andanalyze_blob_columns()NOT NULLin generatedALTER TABLEstatements when the column was originally non-nullableFixes #1434
Test plan
NOT NULLblob column, runmigrate_columns(), verifyIS_NULLABLEremainsNOmigrate_columns(), verify it remains nullablemigrate_columns(dry_run=True)and inspect generated SQL for correctNOT NULLplacement🤖 Generated with Claude Code