Skip to content

Fix dependencies missing from pom.xml#80

Merged
jimexist merged 2 commits into
datafusion-contrib:mainfrom
adamreeve:pom_fix
Sep 5, 2023
Merged

Fix dependencies missing from pom.xml#80
jimexist merged 2 commits into
datafusion-contrib:mainfrom
adamreeve:pom_fix

Conversation

@adamreeve
Copy link
Copy Markdown
Contributor

@adamreeve adamreeve commented Sep 5, 2023

Because of the way datafusion-java creates custom artifacts, the dependency information isn't automatically included in the generated pom.xml. This can lead to confusion for users when they don't realise they need to install an extra dependency.

This fixes the problem by editing the pom.xml to add the required dependencies.

The generated dependencies look like:

  <dependencies>
    <dependency>
      <groupId>org.slf4j</groupId>
      <artifactId>slf4j-api</artifactId>
      <version>1.7.36</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.arrow</groupId>
      <artifactId>arrow-format</artifactId>
      <version>13.0.0</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.arrow</groupId>
      <artifactId>arrow-vector</artifactId>
      <version>13.0.0</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.arrow</groupId>
      <artifactId>arrow-c-data</artifactId>
      <version>13.0.0</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.arrow</groupId>
      <artifactId>arrow-memory-unsafe</artifactId>
      <version>13.0.0</version>
      <scope>runtime</scope>
    </dependency>
  </dependencies>

@jimexist jimexist merged commit 0ecf5d5 into datafusion-contrib:main Sep 5, 2023
@adamreeve adamreeve deleted the pom_fix branch September 5, 2023 05:27
jimexist added a commit that referenced this pull request Sep 5, 2023
@jimexist
Revert "Fix dependencies missing from pom.xml (#80)"
14215a1 
This reverts commit 0ecf5d5.
@jimexist jimexist mentioned this pull request Sep 5, 2023
Merged
jimexist added a commit that referenced this pull request Sep 5, 2023
@jimexist
Revert "Fix dependencies missing from pom.xml (#80)" (#81)
0da0c3a 
This reverts commit 0ecf5d5.
@jimexist
Copy link
Copy Markdown
Collaborator

jimexist commented Sep 5, 2023

Publishing failed so I had to revert

@adamreeve
Copy link
Copy Markdown
Contributor Author

adamreeve commented Sep 5, 2023

Hi @jimexist, where did it fail? It looks like it passed on the "release" action: https://github.com/datafusion-contrib/datafusion-java/actions/runs/6080556797/job/16495138255

The only failure I see is on the "build" action: https://github.com/datafusion-contrib/datafusion-java/actions/runs/6080556796/job/16494678153, but that looks unrelated to my change, and GitHub was having issues around that time: https://www.githubstatus.com/incidents/smdz34v7j8q0

jimexist added a commit that referenced this pull request Sep 6, 2023
@jimexist
Revert "Revert "Fix dependencies missing from pom.xml (#80)" (#81)"
b5e842e 
This reverts commit 0da0c3a.
jimexist added a commit that referenced this pull request Sep 6, 2023
@jimexist
Revert "Revert "Fix dependencies missing from pom.xml (#80)" (#81)" (#84
1dc6b8d 
)

This reverts commit 0da0c3a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamreeve @jimexist