Skip to content

Add retry mechanism to telemetry requests#617

Merged
saishreeeee merged 3 commits intomainfrom
telemetry-retry
Jul 23, 2025
Merged

Add retry mechanism to telemetry requests#617
saishreeeee merged 3 commits intomainfrom
telemetry-retry

Conversation

@saishreeeee
Copy link
Copy Markdown
Contributor

@saishreeeee saishreeeee commented Jun 25, 2025 •
edited
Loading

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Retry mechanism for telemetry requests

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

PECOBLR-586

@saishreeeee saishreeeee marked this pull request as draft June 25, 2025 06:28
@saishreeeee saishreeeee self-assigned this Jun 25, 2025
@saishreeeee saishreeeee changed the title Add retry mechanism for telemetry requests Fit and finish of telemetry (retries and server side flag integration) Jun 25, 2025
@saishreeeee saishreeeee changed the title Fit and finish of telemetry (retries and server side flag integration) Add retry mechanism to telemetry requests Jun 25, 2025
@saishreeeee saishreeeee marked this pull request as ready for review June 25, 2025 12:40
@saishreeeee saishreeeee marked this pull request as draft June 26, 2025 05:06
@saishreeeee saishreeeee marked this pull request as ready for review June 27, 2025 07:14
vikrantpuppala
vikrantpuppala reviewed Jun 30, 2025
View reviewed changes
Comment thread src/databricks/sql/exc.py Outdated
Comment thread tests/e2e/test_telemetry_retry.py Outdated
Comment thread tests/e2e/test_telemetry_retry.py Outdated
Comment thread tests/e2e/test_telemetry_retry.py Outdated
Comment thread src/databricks/sql/telemetry/telemetry_client.py Outdated
Comment thread src/databricks/sql/telemetry/telemetry_client.py Outdated
Comment thread tests/e2e/test_telemetry_retry.py Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 17, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 17, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 17, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 19, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

jprakash-db
jprakash-db approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jprakash-db jprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit comments

Comment thread src/databricks/sql/telemetry/telemetry_client.py Outdated
Comment thread tests/e2e/test_telemetry_retry.py Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 21, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

vikrantpuppala
vikrantpuppala reviewed Jul 23, 2025
View reviewed changes
Comment thread tests/e2e/test_telemetry_retry.py
Comment thread src/databricks/sql/telemetry/telemetry_client.py
@saishreeeee
telemetry retry
af1851b 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
tests
f971360 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee saishreeeee merged commit 71d306f into main Jul 23, 2025
23 checks passed
@saishreeeee saishreeeee deleted the telemetry-retry branch August 1, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@vikrantpuppala vikrantpuppala vikrantpuppala approved these changes

@jprakash-db jprakash-db jprakash-db approved these changes

Assignees

@saishreeeee saishreeeee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saishreeeee @jprakash-db @vikrantpuppala