Ignore Pipelines ANSI backend default drift - #6813
Open
shreyas-goenka wants to merge 7 commits into
Open
shreyas-goenka wants to merge 7 commits into
shreyas-goenka wants to merge 7 commits into
Conversation
shreyas-goenka
marked this pull request as ready for review
September 23, 2026 11:36
shreyas-goenka
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
September 23, 2026 11:36
Collaborator
Integration test reportCommit: 4e2eda5
6 interesting tests: 4 FAIL, 2 flaky
Top 11 slowest tests (at least 2 minutes):
|
denik
reviewed
Sep 23, 2026
| pipelines: | ||
| foo: | ||
| configuration: | ||
| spark.sql.ansi.enabled: "true" |
Contributor
There was a problem hiding this comment.
why did you add this here? and in other tests?
denik
requested changes
Sep 23, 2026
denik
left a comment
denik
left a comment
Contributor
There was a problem hiding this comment.
I don't think we want to modify every single test for this?
Contributor
Author
|
@denik the other solution would be to wait for a TF bump? |
Contributor
Author
|
I'll check if we can just a prod rollback. This is a mistake on the lakeflow side. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Treat
spark.sql.ansi.enabled: "true"as a Pipelines backend default in the direct engine. Set the value explicitly in pipeline acceptance fixtures and shared templates to make the tests pass for TF, update the fake Pipelines API to match the backend, and regenerate affected goldens.Why
The Pipelines API now injects this setting into every pipeline configuration. Without the default rule, direct-engine plans report persistent drift; without explicit fixture values, Terraform acceptance tests also report updates.
Tests
task checkspass.This PR was written by Codex.