direct: make model_serving_endpoints RemapState a dumb copy (surface ForceSendFields at remote root) - #6812
Draft
denik wants to merge 1 commit into
Draft
direct: make model_serving_endpoints RemapState a dumb copy (surface ForceSendFields at remote root)#6812denik wants to merge 1 commit into
denik wants to merge 1 commit into
Conversation
… root RemapState sourced ForceSendFields from the nested EndpointDetails, which the auto-copier (root ForceSendFields only) cannot reproduce. Surface it on the ModelServingEndpointRemote root in newModelServingEndpointRemote (filtered to the wrapper's own fields) and read it there in RemapState, making RemapState a plain subset copy. Add marshal-based MarshalJSON/UnmarshalJSON so the wrapper's extra fields survive the JSON state round-trip (mirrors VectorSearchEndpointRemote). Side effect: the plan remote_state now force-sends the surfaced fields, so the per-engine direct plan goldens are regenerated. No action/diff changes. Co-authored-by: Isaac <[email protected]>
Collaborator
Integration test reportCommit: a532a2a
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep toward replacing hand-written
RemapStatewith the automatic copier.model_serving_endpoints'RemapStatesourcedForceSendFieldsfrom the nestedEndpointDetails(state.EndpointDetails.ForceSendFields), which the auto-copier — which readsForceSendFieldsfrom the remote root — cannot reproduce. This surfaces the FSF on theModelServingEndpointRemoteroot (populated innewModelServingEndpointRemote, filtered to the wrapper's own field names) and reads it there inRemapState, makingRemapStatea plain subset copy.marshal-basedMarshalJSON/UnmarshalJSONare added so the wrapper's extra fields survive the JSON state round-trip (mirrorsVectorSearchEndpointRemote).Caveat worth reviewing: because the wrapper now honors
ForceSendFields, the planremote_statedisplay force-sends the surfaced fields (e.g. emptydescription/route_optimized, forced nestedconfig). This only affects the per-engine*.direct.*plan goldens (regenerated here); there are no action/diff changes andTestAll/acceptance pass.This pull request and its description were written by Isaac.