Conversation
ResourceSecret's RemapState renamed effective_value/effective_owner to value/owner and dropped output-only fields. Move that into a shared remapSecretRemote helper applied wherever the remote is produced (DoRead/DoCreate/DoUpdate), so the remote is already mapped and RemapState becomes an identity no-op. Remove it; the adapter returns the remote unchanged. Plan remote_state now shows the mapped value/owner and omits output-only fields; the direct-only update-value golden is regenerated. Prep for replacing RemapState with the automatic copier. Co-authored-by: Isaac <[email protected]>
Collaborator
Integration test reportCommit: b51daa3
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep toward replacing hand-written
RemapStatewith the automatic copier.ResourceSecret'sRemapStaterenamedeffective_value/effective_ownertovalue/ownerand dropped output-only fields. This moves that transform into a sharedremapSecretRemotehelper applied at every remote-producing path (DoRead/DoCreate/DoUpdate), so the remote is already mapped andRemapStatebecomes an identity no-op — removed.Plan
remote_statenow shows the mappedvalue/ownerand omits output-only fields; the direct-onlyupdate-valuegolden is regenerated.secretsacceptance passes.This pull request and its description were written by Isaac.