Conversation
…absent Make the fake server match cloud for two clears the direct engine can't apply, so the local suite catches them instead of only the nightly cloud run: - MLflow UpdateModel now returns 400 "Description cannot be empty" when the description is absent/empty (the CLI drops the emptied value via omitempty), and - VectorSearchEndpoint PATCH only applies target_qps when the request actually sends it, so removing it from config leaves the old value in place (drift). Adds resources/models/clear-description-rejected and resources/vector_search_endpoints/drift/target_qps_removed to lock in the behavior, and stops resources/models/readplan-permissions from clearing a description (which the real backend rejects) so it focuses on permission removal. Co-authored-by: Isaac <[email protected]>
Collaborator
Integration test reportCommit: 2fa8faa
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local fake server was more lenient than the real API for two field clears, so the field-removal invariant marked them
CANNOT_REMOVEbased on the cloud failure (models.description,vector_search_endpoints.target_qps) even though they passed locally. This makes the fake server reproduce the cloud behavior, so the local suite catches these directly instead of relying on the nightly cloud run.UpdateModelnow returns400 "Description cannot be empty"when the description is absent/empty (the direct engine drops the emptied value viaomitempty).PatchEndpointonly appliestarget_qpswhen the request actually sends it, so removing it from config leaves the old value in place (drift) — matching the real backend.Adds
resources/models/clear-description-rejectedandresources/vector_search_endpoints/drift/target_qps_removedto lock in the behavior. Also stopsresources/models/readplan-permissionsfrom clearing a description (which the real backend rejects with the same 400) so it focuses on permission removal.This pull request and its description were written by Isaac.