Make file count validation to not do remote path checks - #6507
Closed
andrewnester wants to merge 4 commits into
Closed
andrewnester wants to merge 4 commits into
andrewnester wants to merge 4 commits into
Conversation
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 3a6f21e
Top 8 slowest tests (at least 2 minutes):
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Make file count validation to not do remote path checks
Why
files_to_validatecheck which is run onbundle validateand only used to count local files to be uploaded did a remote calls to check that remote paths are there even though it should notDiscovered in #6084 where the remote path is not known and existent until the deploy
Tests
Covered by existing acceptance tests