Add ./task doctest to run Python doctests - #6089
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: bf30cbd
11 interesting tests: 4 SKIP, 3 FAIL, 3 RECOVERED, 1 KNOWN
|
denik
enabled auto-merge
July 29, 2026 08:42
Runs the doctest runner over every Python file that contains a `>>>` prompt (found via git grep). Wired into `task test` so doctests run in CI. Co-authored-by: Isaac
denik
force-pushed
the
denik/doctests
branch
from
September 1, 2026 14:03
bf30cbd to
a2fb43b
Compare
janniklasrose
approved these changes
Sep 1, 2026
Comment on lines
+23
to
+27
| out = subprocess.check_output( | ||
| ["git", "grep", "-l", "--untracked", "--no-color", "-F", ">>>", "--", "*.py"], | ||
| cwd=ROOT, | ||
| text=True, | ||
| ) |
Member
There was a problem hiding this comment.
nice, better than keeping an explicit list!
denik
added a commit
that referenced
this pull request
Sep 1, 2026
#6443 masks a Lakebase oneof member under its group name, and #6089 adds ./task doctest. The first lands on rows this catalog was already recording as errors: nine of them, across postgres_projects, postgres_branches and postgres_endpoints, become OK or SUPPRESSED. Which is the point of the exercise -- those rows named the bug in the API's own words ("Unknown field path in update_mask") and now name its absence. Co-authored-by: Isaac
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
## Why We have doctests in a handful of Python helpers but nothing runs them. This adds `./task doctest`, wired into `task test` so they run locally and in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We have doctests in a handful of Python helpers but nothing runs them. This adds
./task doctest, wired intotask testso they run locally and in CI.