Repository navigation
Conversation
Member
Author
|
Just noting that I'm writing more in-depth tests for manipulation functions now. |
honno
force-pushed
the
smoke-tests
branch
2 times, most recently
from
November 12, 2021 13:48
f5d1a77 to
1b01e11
Compare
Member
Author
Annnd statistical functions. |
asmeurer
reviewed
Nov 15, 2021
honno
force-pushed
the
smoke-tests
branch
2 times, most recently
from
December 6, 2021 20:49
490264e to
326eff8
Compare
honno
commented
Dec 6, 2021
asmeurer
reviewed
Dec 6, 2021
Closed
honno
changed the title
honno
marked this pull request as ready for review
December 7, 2021 12:32
asmeurer
reviewed
Dec 7, 2021
asmeurer
reviewed
Dec 7, 2021
asmeurer
reviewed
Dec 7, 2021
Member
Author
|
Just noting that there are some new utils that could be moved into the helper modules, but I'd rather finishing implementing the rest of the tests first so as to not prematurely refactor. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should result in at least minimal coverage for every function in the spec. My idea is that smoking the functions is easy (ignoring complicated kwarg for now), and personally this process lets me pick out what tests I'm comfortable in developing for the near-future. Commits start from #35.