Skip to content

Update test_sign for complex inputs - #227

Merged
honno merged 2 commits into
data-apis:masterfrom
mtsokol:update-test-sign
Jan 10, 2024
Merged

honno merged 2 commits into
data-apis:masterfrom
mtsokol:update-test-sign

Conversation

@mtsokol

@mtsokol mtsokol commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

Hi!
This PR updates test_sign for complex inputs to align with Array API.

Relevant discussion: numpy/numpy#25441 (comment)

@honno
honno self-requested a review January 8, 2024 20:16

@honno honno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I replaced use of xp.abs with math.abs, as refimpl only pertains to Python scalars as opposed to 0d arrays.

@honno
honno merged commit ae0017a into data-apis:master Jan 10, 2024
@mtsokol
mtsokol deleted the update-test-sign branch January 10, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants