Tests for operators #27

Activity

1. honno commented on Oct 13, 2021

   

   honno

   on Oct 13, 2021 · Hidden as off-topic

   Last edited by honno

   show commentMore actions
2. asmeurer commented on Oct 13, 2021

   

   asmeurer

   on Oct 13, 2021

   MemberAuthor

   More actions

   It's not necessary to test both the dunder method and the operator. Python will call the dunder method when the operator is used. The only slight hitch to that is the __r*__ methods are only called when the left operand returns NotImplemented, so we generally have to test them directly. As far as the actual pytest parameter ids, I think either way looks fine.
3. honno commented on Oct 14, 2021

   

   honno

   on Oct 14, 2021

   Member

   More actions

   Ah I misunderstood this issue, I see now.
4. honno commented on Oct 28, 2021

   

   honno

   on Oct 28, 2021

   Member

   More actions

   Tackling this next. My first idea is to eval expression parameters e.g.

   @pytest.mark.parametrize("expr", ["xp.add(x1, x2)", "x1 + x2"])
   @given(*hh.two_mutual_arrays(dh.numeric_dtypes))
   def test_add(expr, x1, x2):
       out = eval(expr)
       ...

   As-is this doesn't work out for inplace operators nicely. I'll experiment more and hopefully come up with something better. Maybe a custom pytest fixture or decorator which passes an out parameter (that could be x1 in inplace operations), so the test method body doesn't need to worry how it was evaluated. Inplace operations with scalars are something I'd also leave last heh.
5. asmeurer

   closed this as completedin #35on Dec 6, 2021