Skip to content

Clarify extensions should live in specified namespaces #501

Closed

Description

@honno

I noticed our newly introduced FFT stubs live in fourier_transform_functions.py, which might implicitly communicate those extensions should live in the xp.fourier_transform_functions namespace (xp being the top-level Array API namespace), where presumably we want adopters to use xp.fft like say NumPy has it.

So that can be renamed, but this brings up that there's no explicit clarification in the spec that the linalg and fft extensions should indeed live in those respective namespaces. I think a note could live in all extension pages (currently just Linear Algebra and Fourier transform Function) explaining that the respective functions should be present in these specific namespaces.

Activity

  1. honno commented on Nov 3, 2022

    @honno
    MemberAuthor

    In todays meeting we were in agreement for both points (fourier_transform_functions.py -> fft.py and the notes), so I'll submit a PR.

  2. honno commented on Nov 3, 2022

    @honno
    MemberAuthor

    I completely missed #470, which aims to do the latter point (note that these extensions must live in specified namespaces).

  3. rgommers commented on Nov 28, 2022

    @rgommers
    Member

    Fixed by gh-470

  4. added this to the v2022 milestone on Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions