You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Clarify extensions should live in specified namespaces #501
I noticed our newly introduced FFT stubs live in fourier_transform_functions.py, which might implicitly communicate those extensions should live in the xp.fourier_transform_functions namespace (xp being the top-level Array API namespace), where presumably we want adopters to use xp.fft like say NumPy has it.
So that can be renamed, but this brings up that there's no explicit clarification in the spec that the linalg and fft extensions should indeed live in those respective namespaces. I think a note could live in all extension pages (currently just Linear Algebra and Fourier transform Function) explaining that the respective functions should be present in these specific namespaces.
Activity
honno commentedon Nov 3, 2022
In todays meeting we were in agreement for both points (
fourier_transform_functions.py -> fft.pyand the notes), so I'll submit a PR.honno commentedon Nov 3, 2022
I completely missed #470, which aims to do the latter point (note that these extensions must live in specified namespaces).
rgommers commentedon Nov 28, 2022
Fixed by gh-470