Repository navigation
console calculator is done - #1
Open
dashanutikova wants to merge 2 commits into
Open
dashanutikova wants to merge 2 commits into
dashanutikova wants to merge 2 commits into
Conversation
kekulta
reviewed
May 14, 2024
| public class Calculator { | ||
| Scanner scanner = new Scanner(System.in); | ||
|
|
||
| public void addCostToTheOrder(ArrayList<Position> listOfOrder, String positionName) { |
There was a problem hiding this comment.
Ты пишешь логику в нестатическом и затем никак не используешь это. Передача объектов по ссылке
это более императивный подход. Более Java way будет хранить список заказов внутри класса калькулятора.
Owner
Author
There was a problem hiding this comment.
тут не поняла немного. Ты имеешь в виду создавать listOfOrders в Calculator и вообще всю логику работы с ним осуществлять только в классе Calculator?
There was a problem hiding this comment.
Да, таким образом ты можешь инкапсулировать всю логику работу и оставить только несколько методов например: addOrder(name, cost), getTotalCost(), getCostByPerson(personsCount).
| @@ -0,0 +1,26 @@ | |||
| public class RubleFormatter { | |||
There was a problem hiding this comment.
Здорово, что форматтер вынесен в отдельный класс, молодец!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create calculator console app